We've had a topic like this in the past.
Basically, iPods are fine, but other portable music players are a much better deal as many of them support more formats, have longer battery life, more features, etc...
I don't own a portable music player but Creative labs music players are often a better alternative to an iPod.