Do they appeal to you?
On the upside, they add longevity to games. Take a look at the heart pieces in the Zelda series, the Skulltulas and Poes in Ocarina of Time, the Masks in Majora's Mask, the Chaos Emeralds in Sonic, the Stars and Red Coins in the Mario series, etc. Personally, I love collecting things in games, and it always gives me great pleasure to finally "beat" the game proper by collecting absolutely everything.
On the downside, collecting endless items can become tedious over time. Collecting may appeal to some (like myself), but may irritate the casual gamer who simply can't be bothered to spend hours searching for things in a massive Hyrule Field like environment.
And then there's the downright ugly. For example, Wind Waker. Collecting thousands of Rupees to have Maps translated by a lycra wearing elf pervert to then discover that the aforementioned Maps you've spent hours searching for point to a place on your Map that you haven't bothered filling in yet because you've got to go and buy bait from Beedle to throw to each fish that you have to search for on every god damn screen before individually sailing to each place in order to find a miniscule spot in which you can find a tiny little fragment of the Triforce. I mean, who's idea was it to completely ruin the entire game with this interminable segment?!
Your thoughts on collecting things in games, please.
Thanks.