I personally like Rock Band 2 better, though I have a few songs on Guitar Hero I like. I will personally play whichever game has songs I am in the mood for.

So, depending on what songs I want to play, my vote usually jumps back and forth, though Rock Band 2 has more songs I enjoy.