Cloud certainly has the hair for a rocker. Can't imagine what he'd play, though.
Any of the more prominent females in the series could be a lead singer.
Barret would be on the sax, definitely.
Squall seems like a bass player to me.