If Yoshi's Island counts as a Mario game then that is my favorite, hands down.

If Super Mario RPG counts as a Mario game then that is my favorite.

Otherwise, it's a tossup between Super Mario Bros. 3 and Super Mario World. I'll probably have to go with SMB3. It's quirkier.