Question is in the title!

This isn't just limited to this generation - so if you preferred the rectangularness of the NES controller or the smooth curves of the 360 controller... just say!

For me it was the N64, that was pretty much the perfect controller for me. Even with the weight rumble pak plugged in.