Never had too much of a preference, never used a controller I didn't like. The only criticism I would have against one is that I wish Nintendo had a second stick on the N64 controller, since four camera buttons was forward-looking as to where games were headed, but not quite far enough ahead.

I'm partial to having analog sticks horizontally aligned, it feels more intuitive for shooters and, of course, katamari ^_^