I'm pretty indifferent to both of them, so there's no favourite. I barely used either of them in battle as they didn't interest me more than other characters did, and I picked my characters based on who I liked rather than who did the best damage or anything.

Vincent was as annoying for his brooding as Yuffie was for her scamming, but they both had cool moments too so... eh.