I wear tight-fitting boxers when in the army. That eliminates chaffing between one's legs, and also doesn't let precious equipment swing about.

When off-duty... regular briefs, mostly. Cannot defeat that wonderful bullocks-hugging sensation.