Midgar would definitely be my choice if we're talking about favourite cities.

My favourite town would actually derive from Midgar itself. Wall Market. It just had pretty much everything. So many memorable NPC's as well from Big Bro, to Mukki and the Don himself, of course. Also, the cross-dressing side quest was something I'd never experienced in a game when I was a teenager. It blew my tiny mind.