They're fine as long as they're balanced.

Remember that made up roles help mafia more than town, though, because scum can claim a fanciful role if they wish, and town will find claims harder to believe.

Unless you tell everyone that certain made up roles will be included in advance, of course.